View Single Post
Old 08-18-2018, 10:44 AM   #7
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,476
Karma: 8025702
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by AntonGolubev View Post
Hi Chaley,

Do you know if Kovid accepts pull requests? How it works with code contribution with Calibre community?

Kind regards,
Anton
Yes, he does accept submissions either as patch files or pull requests. See https://manual.calibre-ebook.com/develop.html for more information.

What I have seen over my 8 years of working with Kovid is that he is truly happy to accept submissions. He does review for technical correctness and conformance with calibre's architecture, and for "suitability" with current and future calibre. He isn't shy about telling you what he thinks and he will work with you to "fix" things he thinks need changing. He does like it if you will stay around to fix things in your changes should the need arise.

If you are serious then I suggest you open an enhancement request at https://bugs.launchpad.net/calibre, describing what you want to implement. Kovid will tell you at that point if he has any requirements such as being implemented in the GUI and on the command line, where the option is set, and error handling. This could save both of you some time.
chaley is offline   Reply With Quote