Thread: [GUI Plugin] Goodreads Sync
View Single Post
Old 08-07-2018, 09:41 PM   #1143
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by Iceybones View Post
I think I've narrowed it down to this block of code. Thoughts?
I can't look at the plugin at the moment. That looks like code in the edition handling and it getting the ISBN. You would need to replicate that, except for the last line, to get the ASIN as well.

But, there will be other changes needed. The "goodreads_edition_book" is being initialised somewhere, when it is selected it is copied to another object for the book and later the book in the library is updated. Finding all the instances of "isbn" in the plugin and replicating that will probably get you close.

And unfortunately, this sort of thing should be a configurable option. Some people will want to get the ASIN this way, some won't.

Overall, I can see the desire for this. I don't tend to use the ASIN much myself, so haven't felt the loss. If you want to do it and give me the changes, I'll be happy to add it to the plugin. Otherwise, I might do it when I get bored.
davidfor is offline   Reply With Quote