View Single Post
Old 08-05-2018, 04:01 PM   #2853
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,033
Karma: 4604637
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by hoperises View Post
I just updated to the latest version of fanficfare and it still overwrites. It is apparently a new feature:

"- Calibre Plugin: Remove ebook formats before update, overwrite or unnew so that the previouis version ends up in trash instead of just copied over."

This is a step back, please fix the problem.
I can understand that the message above is ambiguous.

The code works as follows:
  1. Make a copy of the existing epub
  2. Perform EPUB update on that copy
  3. Delete the existing epub in the library (fff_plugin.py:1938)
  4. Add the updated copy back to the library book (fff_plugin.py:1944)

The only thing that changed was the addition of step 3. Before step 4 directly overwrote the pre-existing epub file. Now, the pre-existing epub is available in trash.

I've just tested it again on Windows10 and on MacOS 10.14 and it does what I have described.

If this is a problem you can reproduce, please post:
  • Your OS
  • A copy of the pre-update epub
  • A copy of the post-update epub
  • A calibre debug log of performing the update (under Calibre Preferences drop down.)
JimmXinu is offline   Reply With Quote