View Single Post
Old 07-31-2018, 02:07 PM   #26
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,691
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
Mac is double click in bookbrowser to launch a tab. A single-click would interfere with just highlighting.
That's what I thought. And that's exactly what's happening on KDE. Its single-click-to-open feature is essentially changing the "activated" signal of QTreeView into a single-click event.

I'm wondering what would happen if we connected Book View's m_TreeView "doubleClicked" signal to EmitResourceActivated in MainUI/BookBrowser.cpp instead of using the clearly platform-variable "activated" signal that we now use. We'd lose the ability to use Enter/Return to open the resource when it was highlighted, but I'm not certain that works on all Platforms as it is. That's why I was asking what hitting Enter on OS X did when a resource was highlighted in Book Browser.

If using doubleClicked solves the problem on KDE (and everybody else is already used to using double-clicks to open resources from the Book Browser any way), then perhaps we can add a platform independent signal/slot to MainUI/BookBrowser.cpp that will capture the Enter keystroke and launch the resource highlighted in m_TreeView (if the selected entry has a valid index, of course).

Just spit-balling really.

Last edited by DiapDealer; 07-31-2018 at 02:12 PM.
DiapDealer is offline   Reply With Quote