Quote:
Originally Posted by geek1011
Hmm. I'm not totally convinced this is a good idea. This would add a lot of parsing complexity, make patches less readable, and increase the change of mistakes and bugs. The only benefits would be shorter patches and less comments if I understand this correctly.
Also, did you get the quotes working properly?
|
The last first.
I think so. Thanks. There was an extra "
' " hidden.
If you aren't convinced, then you shouldn't do.
Don't worry about. Your decision on the parameter/variable will be the best.
You had fill the main goal
(zlib support
).
Just in case this helps (I hope so):
I think is a question of choosing between an universal solution and optimized one.
In the first case final user must choose (one by one) all his/her devices need.
And very important: you have spare time, because you are done.
In the second one, user gets what his/her device needs in exchange of a device id, but must run once per device.
You must think on and code.
This reminds me... the code is not optimized at all (there is an entire css four times repeated) and we overload it with more (four or six options for one only device is a lot of dead code).
So, as a final user, what do you want? Do you prefer simplicity or universality?
And you developer?
Yours is the last word. Thanks.
Good luck.