View Single Post
Old 07-14-2018, 09:41 AM   #124
geek1011
Wizard
geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.
 
Posts: 2,808
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
Quote:
Originally Posted by norbusan View Post
Good question, something I have asked, too - including the commenting of the empty overrides.

I have submitted a pull request to allow reading a config file from a cmd line argument or stdin, and I would alter the question here: what besides the actual firmware zip file is version dependent? I see two times the version appearing in the yaml file: the `version` tag and the `in` tag.

Does the `version` tag carry any inherent meaning?

And if not, would it be an option (I can look at the code) to override the `in` tag with a command line argument? It really seems strange that everything looks so version independent but the version number still appears.
That exists for 2 reasons. Firstly, in the future, I may do a check on the version for the downloaded firmware, especially with the recently misleading version numbers in the update zip. Secondly, I want users to consciously upgrade their patches, not just blindly copy and paste.

For overriding the in tag, it would be simple (just setting cfg.In). I would need to add pflag for command line parsing, so tell me before you make a PR, if you are planning to. I can do this myself if you want.
geek1011 is offline   Reply With Quote