Thread: User Interface plugins involving loops
View Single Post
Old 06-14-2018, 08:08 PM   #9
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by jackie_w View Post
Yes, that's exactly what it is The perils of copying code from other people when you don't fully understand it. I used kiwidude's ExtractISBN plugin as my "guru" and a timeout didn't seem totally out-of-place in this context. I've just been back to check. I see that, although 'timeout' is an argument, the code which used it has been commented out. I'll get rid of it if it's not part of the jobs system.

This begs a follow-up question. The last arg of that same method is 'in_process' is this also not a part of calibre code?

Perhaps I need to examine a few more thread/jobs plugins to see what other redundancies I may be perpetuating. However, I think kiwidude probably wrote most of them so he may have a "house style".
"in_process" isn't something that rings a bell for me from kiwidudes plugins, so I had a look at ExtractISBN. It is only used for an extra debugging statement. And it isn't really used. It defaults to True, but nothing that calls that function sets it to anything else.
davidfor is offline   Reply With Quote