Quote:
Originally Posted by kovidgoyal
2. No idea, that's not from calibre code, is it from a plugin you copied?
|
Yes, that's exactly what it is
The perils of copying code from other people when you don't fully understand it. I used kiwidude's ExtractISBN plugin as my "guru" and a timeout didn't seem totally out-of-place in this context. I've just been back to check. I see that, although 'timeout' is an argument, the code which used it has been commented out. I'll get rid of it if it's not part of the jobs system.
This begs a follow-up question. The last arg of that same method is 'in_process' is this also not a part of calibre code?
Perhaps I need to examine a few more thread/jobs plugins to see what other redundancies I may be perpetuating. However, I think kiwidude probably wrote most of them so he may have a "house style".