MobileRead Forums - View Single Post - kobopatch

jackie_w · 04-28-2018, 12:16 PM

@geek1011,

Here are my results using kobopatch v5:

Test details:

I used the Win64 version of kobopatch.

I used my own values in the various .yaml files. This includes:

some different replacement values than those in GeoffR's default .patch files
a lot of disabled patches
a couple of extra personal patches for libnickel.so.1.0.0 not present in GeoffR's defaults

Good News:

Comparing the GeoffR version of KoboRoot.tgz with the kobopatch version of KoboRoot.tgz ...
Checksums (both md5 and sha256) for each of the 4 files included in KoboRoot.tgz compared exactly.

Bad News: nickel.yaml only ...

When I tried to uncomment the last line of patch "Custom reading footer style", kobopatch fell in a heap with this error message

Code:

Fatal: Could not read and parse patch file nickel.yaml: error parsing patch file: yaml: line 73: did not find expected ',' or '}'

I think you can easily reproduce it yourself just by uncommenting line 74 (not 73 ???) in the nickel.yaml file you supplied in kobopatch_4.8.10956.zip.

Clutching at straws ... is it something to do with the fact that this option is one of the few which doesn't have same string lengths for Find and Replace? The Replace option is terminated early with a trailing /0, which works OK in the current patching system.

04-28-2018, 12:16 PM	#33
jackie_w Grand Sorcerer Posts: 6,255 Karma: 16544692 Join Date: Sep 2009 Location: UK Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3	@geek1011, Here are my results using kobopatch v5: Test details: I used the Win64 version of kobopatch. I used my own values in the various .yaml files. This includes: some different replacement values than those in GeoffR's default .patch files a lot of disabled patches a couple of extra personal patches for libnickel.so.1.0.0 not present in GeoffR's defaults Good News: Comparing the GeoffR version of KoboRoot.tgz with the kobopatch version of KoboRoot.tgz ... Checksums (both md5 and sha256) for each of the 4 files included in KoboRoot.tgz compared exactly. Bad News: nickel.yaml only ... When I tried to uncomment the last line of patch "Custom reading footer style", kobopatch fell in a heap with this error message Code: Fatal: Could not read and parse patch file nickel.yaml: error parsing patch file: yaml: line 73: did not find expected ',' or '}' I think you can easily reproduce it yourself just by uncommenting line 74 (not 73 ???) in the nickel.yaml file you supplied in kobopatch_4.8.10956.zip. Clutching at straws ... is it something to do with the fact that this option is one of the few which doesn't have same string lengths for Find and Replace? The Replace option is terminated early with a trailing /0, which works OK in the current patching system.