View Single Post
Old 04-27-2018, 12:15 AM   #32
geek1011
Wizard
geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.
 
Posts: 2,804
Karma: 7025947
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
Quote:
Originally Posted by sherman View Post
Hi geek1011

A couple of thoughts on your new patch format.

Why not include the patch description as part of each patch, instead of outside in comments? It would make parsing the description easier.

Also, have you thought about more defined versioning information (with regards to firmware version etc), rather than specifying the version in a comment somewhere?

Cheers,
Sherman
That's actually a great idea about the description. I'll implement it this weekend.

As for the versioning, I was considering it, but decided against it. Firstly, the patches will most likely fail if applied to the wrong version. Secondly, it is very difficult to extract the version info from the binary, and thirdly, it is hard to represent things like ranges in an concise way.
geek1011 is offline   Reply With Quote