View Single Post
Old 01-20-2018, 05:33 PM   #12
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,619
Karma: 204624552
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
If we wanted, we could make that warning only in C++ PluginRunner code before launching any output plugins and not use sigil.cfg at all nor change any of the launcher/wrapper python code.
I don't really want to take the choice away from the plugin dev by making the warning mandatory whenever running output plugins with Sigil's dirty flag set. It's really only co-dependent input/output pairs of plugins where I envision there being a need for such a warning.

Quote:
Alternatively, we pass the dirty flag to the plugin and let the plugin code produce the warning and handle it.
This is what I'm leaning toward. For the reasons mentioned above. I realize this
needs to be balanced against altering the plugin framework (which means plugins that utilize it might need need to juggle things in order to support earlier versions of Sigil that don't have the flag).
DiapDealer is offline   Reply With Quote