View Single Post
Old 09-17-2017, 12:11 PM   #11
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,805
Karma: 6000000
Join Date: Nov 2009
Device: many
It should be an easy change and that routine is really only called for toc headings, and the nav. So it should be a very safe change.

I will push something today (or soon) that should fix this issue for us.



Quote:
Originally Posted by DiapDealer View Post
QString.simplfied() collapses internal whitespace, too. But we want it to in many cases. It collapses multiple spaces, and any combination of tabs, linefeeds and carriage returns to a single space (as well as trimming the leading/trailing whitespace).

Would converting br child nodes into line-breaks (which simplified() would ultimately convert to a space) be difficult to accomplish in get_local_text_of_node? If not, should we always do so, or pass a boolean parameter (defaulted to false) that's only true for the GetHeadingsListForOneFile function in Headings.cpp?

If it's awkward, or potentially introduces other complications, I'm not sure if it's worth it (but I'm not opposed to the idea of "fixing" this on principle alone, either).
KevinH is offline   Reply With Quote