View Single Post
Old 09-16-2017, 08:23 PM   #10
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,659
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
QString.simplfied() collapses internal whitespace, too. But we want it to in many cases. It collapses multiple spaces, and any combination of tabs, linefeeds and carriage returns to a single space (as well as trimming the leading/trailing whitespace).

Would converting br child nodes into line-breaks (which simplified() would ultimately convert to a space) be difficult to accomplish in get_local_text_of_node? If not, should we always do so, or pass a boolean parameter (defaulted to false) that's only true for the GetHeadingsListForOneFile function in Headings.cpp?

If it's awkward, or potentially introduces other complications, I'm not sure if it's worth it (but I'm not opposed to the idea of "fixing" this on principle alone, either).

Last edited by DiapDealer; 09-16-2017 at 08:43 PM.
DiapDealer is online now   Reply With Quote