View Single Post
Old 07-08-2017, 11:52 PM   #2329
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,045
Karma: 4604637
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by davidfor View Post
...
Unless you can think of something that would prevent this from working, I'll have a look at it.
I have no objections, as long as it's optional. I'd say default it to off at first, but after it's proven it could default to on.

I think it would be the first adapter with fake chapter URLs, but it would not be the first with getChapterText() getting some 'chapters' from stuff it remembers from doExtractChapterUrlsAndMetadata() or previous pages. base_xenforoforum_adapter.py and adapter_archiveofourownorg.py do too.

However, keep in mind the interactions of epub update (if the 'book' chapter URL is unchanged, that 'chapter' will be reused from epub even if the book notes have changed, etc) and mark_new_chapters / UnNew.
JimmXinu is offline   Reply With Quote