MobileRead Forums - View Single Post

norbusan · 07-01-2017, 01:56 AM

Another comment why all this came up - afais there is *nothing* mentioned in the calibre source code that python2-unrardll is needed, useful, or whatever.

Code:

$ grep -i unrardll `find . -type f`
./src/calibre/utils/unrar.py:    from unrardll import extract
./src/calibre/utils/unrar.py:    from unrardll import names
./src/calibre/utils/unrar.py:    from unrardll import comment
./src/calibre/utils/unrar.py:    from unrardll import extract_member

I think it would make sense to document this dependency somewhere ...

07-01-2017, 01:56 AM	#9
norbusan Zealot Posts: 140 Karma: 82382 Join Date: Jan 2013 Device: Kindle Paperwhite, Kobo Glo, Kobo GloHD	Another comment why all this came up - afais there is nothing mentioned in the calibre source code that python2-unrardll is needed, useful, or whatever. Code: $ grep -i unrardll `find . -type f` ./src/calibre/utils/unrar.py: from unrardll import extract ./src/calibre/utils/unrar.py: from unrardll import names ./src/calibre/utils/unrar.py: from unrardll import comment ./src/calibre/utils/unrar.py: from unrardll import extract_member I think it would make sense to document this dependency somewhere ...