View Single Post
Old 05-15-2017, 06:06 AM   #199
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,506
Karma: 8065348
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by kovidgoyal View Post
@charles: IMO we should keep a global as a fallback and make the argument to the formatter class a named argument. Reduces chances of breaking backwards compat.

...
I pushed a set of changes to my vs2015 repository copy on github.

I tested it using two libraries, lib A with no user template functions and lib B where a user-defined function was used in a composite column. Before the change:
  • the content server saw function errors when looking at lib B when the GUI is showing lib A.
  • the content server saw correct content when the GUI is showing lib B.
After the change, the content server shows correct content no matter which library the GUI is showing.

The change should be fully compatible. It is possible that performance has gone down a smidgen, but not enough for me to measure on my test libraries.
chaley is offline   Reply With Quote