MobileRead Forums - View Single Post

kovidgoyal · 05-14-2017, 09:29 PM

@charles: IMO we should keep a global as a fallback and make the argument to the formatter class a named argument. Reduces chances of breaking backwards compat.

In contexts where there is no GUI and callers do not provide a function set, the template formatter can just fail, as it does today.
I think it's good if we solve this before 3.0. Since 3.0 has other backwards comapt breaks, might as well get them all out of the way at once. Although I think if we keep the global as fallback, there shouldn't be any problems in practice.

It might be a it painful to have the function changing code change two sets of formatter objects, but it shouldn't be to bad, since I dont think there are many places where functions are modified.

05-14-2017, 09:29 PM	#198
kovidgoyal creator of calibre Posts: 45,455 Karma: 27757438 Join Date: Oct 2006 Location: Mumbai, India Device: Various	@charles: IMO we should keep a global as a fallback and make the argument to the formatter class a named argument. Reduces chances of breaking backwards compat. In contexts where there is no GUI and callers do not provide a function set, the template formatter can just fail, as it does today. I think it's good if we solve this before 3.0. Since 3.0 has other backwards comapt breaks, might as well get them all out of the way at once. Although I think if we keep the global as fallback, there shouldn't be any problems in practice. It might be a it painful to have the function changing code change two sets of formatter objects, but it shouldn't be to bad, since I dont think there are many places where functions are modified. Last edited by kovidgoyal; 05-14-2017 at 09:32 PM.