View Single Post
Old 03-03-2017, 02:23 PM   #26
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,849
Karma: 6120478
Join Date: Nov 2009
Device: many
Okay, removed the now obsolete use of $.browser.msie in Sigil's version of jquery.wrapSelection.js so it should remove any javascript errors from the Inspector Console window. It does under my tests.

That just leaves how to handle underline and strike. I can easily now force BookView to add spans with in-line styles to prevent Sigil from introducing "strike" when in BookView and using "u".

If we go ahead with those changes, Sigil, even in BookView will at least generate 100% correct code although ugly and ungainly. BookView will then handle thigns differently than CodeView but I am okay with that given that the code BookView generates at times is truly awful.

I would like to get a fix in the tree for use of strike at least (deprecating u and then undeprecating it is just stupid, so I don't really care about use of "u" or not).

DiapDealer, what do you think?
KevinH is offline   Reply With Quote