Thread: [GUI Plugin] Count Pages
View Single Post
Old 01-19-2017, 08:37 PM   #1007
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by BeckyEbook View Post
Version 1.6.13 - 19 Jan 2017 - by Becky
Added option to download page count from Lubimyczytac.pl website
New: Polish translation

Based on 1.6.12 beta by davidfor
German and Spanish translations was updated for support 1.6.13
Thanks for the new translation and the function. You did base this one a slightly older beta, so I'll merge this with the later version over the weekend.

One thing is, I'm a little hesitant about adding the page download for other sites. The number of users that downloading from Lubimyczytac.pl website will help is relatively small. And what happens if someone wants to add another source? The menu could start getting long. But, the added function is very useful to those who want it. That makes me think about how to handle it.

The simplest is of course just to display all the items. But, I'm going to see the "Lubimyczytac.pl" and want to press it Better would be to have some options in the config to set which menu options are displayed. That way it can be clean for those who want it.

An alternative is to stick with one menu item that is something like "Get page count from web sources". Then choose the source based on the identifiers on that book. Plus a priority for the sources. That way you could set Lubimyczytac.pl as first followed by Goodreads. If the book has both identifiers, then Lubimyczytac.pl will be used, if it only has Goodreads, then the Goodreads will be used. And if the page count isn't found on the first source, should the later ones be tried?

And writing that makes me fell like both options should be available. Anyone with an opinion? Or even better, a useful opinion?

In the meantime, I will merge the code and do some cleanup. Once I have done that I'll decide whether to release it or post a beta. I might release it to get the other changes out and then decide about the best way to handle the multiple web sources.
davidfor is offline   Reply With Quote