Thread: [Conversion Output] KePub Output Plugin
View Single Post
Old 11-06-2016, 06:32 PM   #178
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by jgoguen View Post
Should that be a list in the class, so plugins can override it?
I wouldn't code it as a list. If I was doing it properly, I would probably add a property along the lines of "supports_cover_in_toc". Default that to false in the base OutputPlugin class and set it to true wherever appropriate. That was more than I felt like doing yesterday and the change I made was in keeping with the coding style in of the class and method I was changing. And if we keep adding things like, this Kovid will eventually accept that kepubs are a standard format. Wouldn't we all like to edit kepubs in the calibre editor??? Just two or three changes if anyone is interested.

Also, is the git repository up to date? My local copy doesn't match but I'm not sure which are changes I've meant to throw away.
davidfor is offline   Reply With Quote