View Single Post
Old 02-02-2009, 09:49 AM   #79
Man Eating Duck
Addict
Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.Man Eating Duck juggles neatly with hedgehogs.
 
Posts: 254
Karma: 69786
Join Date: May 2006
Location: Oslo, Norway
Device: Kobo Aura, Sony PRS-650
Fix (?) for pages with deleted scribbles

Hi! First of all, thanks for a great tool, it works very well

I have a small issue, however. It seems that my iLiad will retain a <page>-entry in the XML if you make a scribble on a page and then remove it (xml reformatted for clarity):
Code:
    <page backgroundcolor="#000000" id="1">
      <orientation>0</orientation>
      <height>1024</height>
      <width>768</width>
      <strokes/>
    </page>
    <page backgroundcolor="#000000" id="2">
      <orientation>0</orientation>
      <height>1024</height>
      <width>768</width>
      <strokes/>
    </page>
The merger app vill then add these scribble-less pages as well when you select "Scribbled pages only" . I have the book Edition, if that's interesting.

I don't really want the pages with no scribbles on them. I'm no Java developer, but dived in and made the following change in v1.8-src at ScribbleMerger.java:97

Code:
                    arrScribblePages.add(sp);
                    mapScribblePages.put(new Integer(sp.nPageId), sp);
to

Code:
                // Test for pages with no scribble strokes
                if(sp.arrStrokes.length > 0) {
                        arrScribblePages.add(sp);
                        mapScribblePages.put(new Integer(sp.nPageId), sp);
                    }
This might not be the proper object in which to put this test, but it seems to solve the problem.

@Bert: Maybe you'll want to check that this doesn't break anything, and include it (or something like it) in your next version? It is not extensively tested, though

Last edited by Man Eating Duck; 02-02-2009 at 02:58 PM.
Man Eating Duck is offline   Reply With Quote