View Single Post
Old 09-13-2016, 08:50 AM   #23
GeoffR
Wizard
GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.
 
GeoffR's Avatar
 
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
Quote:
Originally Posted by Katsunami View Post
What does the second line do exactly? In the thread I linked previously, it is mentioned that it adds 'soft margins', but I don't know about the rendering (and associated problems) on Kobo devices to guess what it means.
The second line adds a small amount of padding (an amount proportional to the currently selected font size) to the wrapper div named "book-columns". If no such wrapper div exists then it does nothing. That little bit of padding gives enough room to allow glyphs with side bearing positioned at the edge of a line to be rendered without being clipped by the edge of the viewport.

The fact that the glyphs would be clipped in the first place is probably because of a bug in the KePub reader. (One that isn't present in the ePub reader, which uses a completely different rendering engine.)

The reason that the bug isn't usually noticed in KePubs in normal reading mode is that there the viewport is set to the full size of the screen and the user-selected margins are added by changing the body margin, so the bug is only seen when the margins are set to minimum. In full-screen mode the body margins are supposed to be zero and the margin slider changes the size of the viewport instead, so the bug is seen at all slider positions.

(That is just what I think based on looking at code in the firmware, I don't know all the details.)

Quote:
This slider problem which you mentioned (and which I have already encountered):
Is it a consequence of the added CSS, or is this a bug Kobo should fix in another firmware update?
It is not affected by the CSS. It is a bug in the KePub reader (one that doesn't exist in the ePub reader), but since it is a bug that only arises in full-screen mode, and full-screen mode is not an officially-supported feature, it is unlikely to be a priority for being fixed. I wouldn't hold out any hope that it will be fixed in the future unless Kobo decide to make full-screen mode an official feature available by default, but it is always possible that it will be fixed by accident, i.e. some other change to the code results in the buggy code being removed.

In practice the problem with the margin slider stoppng working after a chapter boundry is crossed is not a major annoyance because once you set the margin slider for one book it becomes the default for the next book and you don't often need to change it again.
GeoffR is offline   Reply With Quote