View Single Post
Old 08-19-2016, 11:53 AM   #1475
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,014
Karma: 4604635
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by kovidgoyal View Post
The heuristics should detect only a single cover, not more than that. If they are indeed replacing more than a single cover image, I'm potentially OK with changing that, but I need more details to decide.
You are correct--only the first sub-book's cover is affected. The user's epub I was testing with only had one sub-book with cover.

And Polish is finding that the first page in the epub is href="1/OEBPS/cover.xhtml" id="a1cover". While there's also a tag <meta name="cover" content="cover"/> that refers directly to a separately image, it's difficult to argue that what Polish is doing is wrong. My mistake suggesting it was.

I have some more thoughts on the matter I want to consider, but I consider modifying Polish off the table.
JimmXinu is online now   Reply With Quote