View Single Post
Old 07-23-2016, 01:19 PM   #41
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,455
Karma: 27757438
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Quote:
Originally Posted by chaley View Post
@Kovid: create_custom_column.ui has disappeared from the source, replaced by setup_ui in create_custom_column.py. Shouldn't the inheriting from Ui_QCreateCustomColumn also be removed? I tried it and the dialog works fine with it gone, but I don't know what the side effects might be.
My rationale for not having a separate setting to control heading position is that it only makes sense to have the heading on the left if you expect the text to be relatively short (i.e. fit in one line). And if that is the case you might as well use a short text display type. It is however true, that one cannot currently use a short HTML column, which may be useful for showing a single link. So I am not particularly opposed to it. I will look at your PR tomorrow, as it is getting late here. Note that you will also have to change the new content server code, in book_details.pyj
kovidgoyal is offline   Reply With Quote