MobileRead Forums - View Single Post

davidfor · 05-24-2016, 07:57 PM

Yes, that's what I should have expected.

The problem was that when I started this, I pulled code from the MTP driver and it's configuration dialog. It handles the configuration at the actual device level rather than one set for the driver. I had a look at doing this for the Kobo driver, but, it broke to much. The parent classes all assume the single configuration and overriding that was more work than I wanted at the time. I thought I had removed all this code, but, I had missed this one bit.

Everything else would have been working properly. This was just a check being done when saving configuration against the current configuration to prevent unnecessary writes. But, it wasn't checking against the correct saved configuration. Putting the null configuration in means that the checks always come as as a change happened, and the correct configuration is saved in the right place.

I fixed this last night, but haven't checked it in yet. I'll do it tonight after some more testing.

05-24-2016, 07:57 PM	#14
davidfor Grand Sorcerer Posts: 24,905 Karma: 47303824 Join Date: Jul 2011 Location: Sydney, Australia Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos	Yes, that's what I should have expected. The problem was that when I started this, I pulled code from the MTP driver and it's configuration dialog. It handles the configuration at the actual device level rather than one set for the driver. I had a look at doing this for the Kobo driver, but, it broke to much. The parent classes all assume the single configuration and overriding that was more work than I wanted at the time. I thought I had removed all this code, but, I had missed this one bit. Everything else would have been working properly. This was just a check being done when saving configuration against the current configuration to prevent unnecessary writes. But, it wasn't checking against the correct saved configuration. Putting the null configuration in means that the checks always come as as a change happened, and the correct configuration is saved in the right place. I fixed this last night, but haven't checked it in yet. I'll do it tonight after some more testing.