[davidfor]

Originally Posted by jackie_w

@David,

As I don't use KoboTouchExtended I'll restrict my comments to the first 3 Tabs.

Some general first thoughts:

• I like the "less cluttered" look.
  
• I'm not sure what the rationale is for what's included on each Tab. E.g, is there a reason why Collections/Covers/Uploads are grouped together rather than having a separate Tab for each? Similarly, Metadata/Advanced?
  

• It's basically because there aren't enough options to fill separate tabs. The minimum size dialog is effectively set by the Formats tab. Which groups were on which tab was really about how they fit
  

  Are Recommendations, Previews, Archived books classed as Metadata? When I see the word "Metadata" in calibre, I assume it's referring to data in my calibre library columns.

  No, I hadn't intended the recommendations etc to be "Metadata". That tab probably should be called "Metadata, On Device & Advanced". The name of "Metadata" group isn't quite right, but I'm not sure what it should be.
  

  This may be a bit premature if you're only at proof-of-concept stage but, I'll say it anyway If I was a new user wondering what some of these options do, I don't think I'd be any the wiser with the Tabbed display than I was with the old all-in-one display.

I don't completely disagree with you on this. I think this is better and I think it will be easier to make better still.

More specific thought:

• Using CollectionsGroupBox as an example - but also applies to CoversGroupBox, MetadataGroupBox:
  
  The first checkbox, 'Manage Collections', seems to be acting as a "controller" for whether to do anything with the other 3 items below (Columns, Create coll, Delete empty). If I have understood this correctly might it be better to remove it and have this checkbox belong directly to the CollectionsGroupBox parent widget. i.e.
  

  class CollectionsGroupBox(DeviceOptionsGroupBox):
      def __init__(self, parent, device):
          ... ...
          self.setCheckable(True)
          ... ...
  
      @property
      def manage_collections(self):
          return self.isChecked()

  I believe all the child-widgets would be automatically enabled/disabled as the CollectionsGroupBox checkbox was checked/unchecked, removing the need for manage_collections_checkbox_clicked()
  (see screencaps below).

• I haven't seen that done in many places, but it seems to work. I'll have to experiment a bit.
  

  This 'run from source' thingy is pretty handy.

Yes it is.

Final thought:

• What are the chances of bringing KoboTouch and KoboTouchExtended together as one driver so that it would be possible to send a batch of epubs as plain-epub or kepub as the whim takes me for this particular batch?

I'm not keen on including the kepub generation into the main driver. And I normally handle this by converting to kepub and then sending it. But, what I think you want is an option while using the extended driver to either quickly turn the kepub conversion on and off without disconnecting, or a "send as epub without conversion" option in a menu somewhere. I'm not sure if there is a way to handle this just at the device driver level. But, I think it might be something I could do from the utilities plugin, with the appropriate support in the extended driver.

Thanks for all the comments.