MobileRead Forums - View Single Post

KevinH · 03-10-2016, 11:59 AM

Found the bug. It seems the gumbo_get_attribute call is not namespace aware. We asked it to find the xlink:href on image tags but it only looks at the local attribute name (href) and so did not detect it. The cover.jpeg itself is detected in the metadata in the opf, so it is never unused. The only way to change that is to use the AddSemantics dialog to change the cover image set.

I will update the gumbo code to allow namespaced searching for attributes to fix this. I will push these changes to master for the next release.

KevinH

ps: fix is now in master and will appear in Sigil-0.9.4
Thanks for your bug report!

03-10-2016, 11:59 AM	#12
KevinH Sigil Developer Posts: 8,873 Karma: 6120478 Join Date: Nov 2009 Device: many	Found the bug. It seems the gumbo_get_attribute call is not namespace aware. We asked it to find the xlink:href on image tags but it only looks at the local attribute name (href) and so did not detect it. The cover.jpeg itself is detected in the metadata in the opf, so it is never unused. The only way to change that is to use the AddSemantics dialog to change the cover image set. I will update the gumbo code to allow namespaced searching for attributes to fix this. I will push these changes to master for the next release. KevinH ps: fix is now in master and will appear in Sigil-0.9.4 Thanks for your bug report! Last edited by KevinH; 03-10-2016 at 04:35 PM.