Quote:
Originally Posted by ij26
I just tried to download a bunch of stories from Fimfiction, and found that while some worked, others return 404 errors (although they seem to download fine in a Web browser).
...
A recent site update might be related. |
The update says that userscripts making use of AJAX calls will be broken, and comparing the two sets of stories suggests a cause for this: all of the ones that work have 8 or fewer groups, and those that don't have 9 or more groups. When there's 9 or more groups you need to click the "show more groups" button to see them all, which is an AJAX call. I bet that the adapter's failing when it follows that link to try getting the complete group list.
I'm currently completely wiped out from several days of not sleeping enough, I'll poke around with this tomorrow if I'm conscious and nobody's beaten me to it. Hopefully the adapter can be updated to the new AJAX calls easily, I use that groups metadata in my library's organization.
Edit: looks like an easy enough fix.
Learning to use Git while having had 3 hours of sleep in the past 48 is beyond me, if this fix is good I assume Jimm will take it.
You should be able to fix this locally by digging into your installed FanFicFare.zip, finding the file adapter_fimfictionnet.py, and replacing the line
Code:
groupResponse = self._fetchUrl("http://www.fimfiction.net/ajax/groups/story_groups_list.php?story=%s" % (self.story.getMetadata("storyId")))
with
Code:
groupResponse = self._fetchUrl("https://www.fimfiction.net/ajax/stories/%s/groups" % (self.story.getMetadata("storyId")))
(while maintaining proper indentation of course).
I just tried one of the 404 stories with that modification and it worked. I'll try the rest now, if I don't edit this further I guess assume that it worked or that I fell asleep.