MobileRead Forums - View Single Post - X-Ray Builder

steinchen · 02-18-2016, 02:07 PM

Just that Mono was already installed. As the compiled files run on Windows I didn't bother installing Visual Studio.
My long term goal would be porting your code to python to use it as a calibre plugin. But as I have an hour a day at most I didn't even finish reading and commenting your code.
I have to say that finding apostrophes doesn't work in the latest commit. Only noticed it last night while reading. In my current book they use ’ (U+2019, which according to ISO 10646 is the preferred apostrophe) for apostrophes and in your code it's a ' (U+0027). I guess some people might use ` (U+0060) or ´ (U+00B4), at least I did as a kid. Regex and I don't really get along but I tried changing

Code:

string punctuationMarks = @"(?(')'s?|')?\b[!\.?,""'\);]*";

to

Code:

string punctuationMarks = @"(?(['´`’])['´`’]s?|['´`’])?\b[!\.?,""'\);]*";

but this also didn't work. Then I tried

Code:

string punctuationMarks = @"(?(’)’s?|’)?\b[!\.?,""'\);]*";

hoping it would search for ’ but this also didn't work.
On the weekend I'll have a closer look at this (and I'll try to learn the regex syntax).

02-18-2016, 02:07 PM	#300
steinchen Junior Member Posts: 4 Karma: 10 Join Date: Feb 2016 Device: Kindle Paperwhite 3	Just that Mono was already installed. As the compiled files run on Windows I didn't bother installing Visual Studio. My long term goal would be porting your code to python to use it as a calibre plugin. But as I have an hour a day at most I didn't even finish reading and commenting your code. I have to say that finding apostrophes doesn't work in the latest commit. Only noticed it last night while reading. In my current book they use ’ (U+2019, which according to ISO 10646 is the preferred apostrophe) for apostrophes and in your code it's a ' (U+0027). I guess some people might use ` (U+0060) or ´ (U+00B4), at least I did as a kid. Regex and I don't really get along but I tried changing Code: string punctuationMarks = @"(?(')'s?\|')?\b[!\.?,""'\);]"; to Code: string punctuationMarks = @"(?(['´`’])['´`’]s?\|['´`’])?\b[!\.?,""'\);]"; but this also didn't work. Then I tried Code: string punctuationMarks = @"(?(’)’s?\|’)?\b[!\.?,""'\);]*"; hoping it would search for ’ but this also didn't work. On the weekend I'll have a closer look at this (and I'll try to learn the regex syntax).