MobileRead Forums - View Single Post

KevinH · 01-23-2016, 01:52 PM

Hi DiapDealer,

"I'll be happier than a pig in slop." Well it's time to start slopping around! To test my theory, I tried my workaround of taking ownership of the clip when an external clip is added. This seems to fix the problem 100% on my Linux box. See my latest commit to Sigil Master.

So if simply changing ownership of a piece of clipboard text (by copying it out and pasting it back unchanged) and not changing anything else in Sigil, stops the bug completely, then I would say there is a bug in qxcbclipboard.cpp. Nothing like that should happen or happens on any other platform.

As to why Sigil, I think Sigil is a heavy user of XHTMLSyntaxHighlighting and when you add to that when you highlight anything in Sigil in xhtml you are sending the textChanged() signal out to the FlowTab and/or CSSTab (when nothing has ever changed in the underlying QPlainTextEdit widget - a bad design of Qt's as far as I can tell - and then emitting another signal from there to tell the MainWindow to tell Preview to Update itself. So there are a lot of signals flying around when someone on Linux / X11 simply selects the text! No other platform has a problem with it.

Anyway, please test my "copying out and pasting back fix" and let me know if the funny highlighting of code problem goes away on your machine. It does on mine!

Once it is confirmed, I will close the slow highlighting issue on Sigil's github.

KevinH

01-23-2016, 01:52 PM	#56
KevinH Sigil Developer Posts: 9,268 Karma: 6565382 Join Date: Nov 2009 Device: many	Hi DiapDealer, "I'll be happier than a pig in slop." Well it's time to start slopping around! To test my theory, I tried my workaround of taking ownership of the clip when an external clip is added. This seems to fix the problem 100% on my Linux box. See my latest commit to Sigil Master. So if simply changing ownership of a piece of clipboard text (by copying it out and pasting it back unchanged) and not changing anything else in Sigil, stops the bug completely, then I would say there is a bug in qxcbclipboard.cpp. Nothing like that should happen or happens on any other platform. As to why Sigil, I think Sigil is a heavy user of XHTMLSyntaxHighlighting and when you add to that when you highlight anything in Sigil in xhtml you are sending the textChanged() signal out to the FlowTab and/or CSSTab (when nothing has ever changed in the underlying QPlainTextEdit widget - a bad design of Qt's as far as I can tell - and then emitting another signal from there to tell the MainWindow to tell Preview to Update itself. So there are a lot of signals flying around when someone on Linux / X11 simply selects the text! No other platform has a problem with it. Anyway, please test my "copying out and pasting back fix" and let me know if the funny highlighting of code problem goes away on your machine. It does on mine! Once it is confirmed, I will close the slow highlighting issue on Sigil's github. KevinH Last edited by KevinH; 01-23-2016 at 02:11 PM.