Quote:
Originally Posted by KevinH
If an epub2 has no guide that is legal. But can an epub2 have an empty guide? If not, then this condition means we are okay (not a bug). As the epub3 should only get the guide element start and end tag if they exist in the the epub2.
So the only way a bug exists is if a validated epub2 can have an empty guide element so that it passes an empty guide through to the epub3 opf.
If the epub2 has no guide element at all, it should not create an empty one in the epub3 opf.
|
I did this test just now: I opened in Sigil 0.9.1 an EPUB 2 with no <guide> in the OPF, validated with epubcheck (no errors or warnings). Sigil added an empty <guide> (i.e., <guide></guide>) to the OPF, and therefore running ePub3-itizer exported the empty <guide> to the EPUB 3 file.
I repeated the test with Sigil 0.9.2 (built from GitHub src), same result.
If I just open Sigil (hence, I get a blank file), I see the empty <guide> in the OPF.
So, I guess the issue is with Sigil, not with the export plugin.
Quote:
Originally Posted by KevinH
Also checking self.guide will not work as we are passing through the guide in the res list and it is built on the fly. So we would have to build up the guide res piece separately in order to prevent an empty guide set from being passed through.
|
You are right on this.