View Single Post
Old 12-15-2015, 01:23 PM   #161
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 9,178
Karma: 6565382
Join Date: Nov 2009
Device: many
Hi Alpe,

If an epub2 has no guide that is legal. But can an epub2 have an empty guide? If not, then this condition means we are okay (not a bug). As the epub3 should only get the guide element start and end tag if they exist in the the epub2.

So the only way a bug exists is if a validated epub2 can have an empty guide element so that it passes an empty guide through to the epub3 opf.

If the epub2 has no guide element at all, it should not create an empty one in the epub3 opf.

Also checking self.guide will not work as we are passing through the guide in the res list and it is built on the fly. So we would have to build up the guide res piece separately in order to prevent an empty guide set from being passed through.

KevinH
KevinH is offline   Reply With Quote