View Single Post
Old 12-10-2015, 11:51 PM   #34
DNSB
Bibliophagist
DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.
 
DNSB's Avatar
 
Posts: 47,143
Karma: 169815798
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
Quote:
Originally Posted by lkstrummer View Post
Thanks for the quick reply. I can't create a new patch right now, but I'll edit this later when I test your suggestion. Interestingly, I uncommented all values for all devices in 3.17.3 and the output file was created without any problems. So it looked like:

find_base_address = `ReadingFooter {\n\tmin-height: 70px;`
#
# Replacement footer height values: Touch/Mini
replace_string = 0011, `min-height: 70px;`, `min-height: 32px;`
replace_string = 0024, `max-height: 70px;`, `max-height: 32px;`
# Replacement footer height values: Glo/Aura
replace_string = 0085, `min-height: 82px;`, `min-height: 40px;`
replace_string = 0098, `max-height: 82px;`, `max-height: 40px;`
# Replacement footer height values: AuraHD/H2O/GloHD
replace_string = 00DA, `min-height: 120px;`, `min-height: 036px;`
replace_string = 00EE, `max-height: 120px;`, `max-height: 036px;`
#
#
Given the changes are made at different addresses, I can't see an issue from doing so. OTOH, making unnecessary changes is generally something to be avoided.
DNSB is offline   Reply With Quote