View Single Post
Old 11-29-2015, 12:19 PM   #22
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,486
Karma: 8025704
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by kaufman View Post
Are you sure its been broken since the beginning. I use those links a fair amount, and I can't believe I've only ever done the google and amazon ones.

I asked for that feature, and I find it hard to believe I've never used it. Or tested it when you implemented it.
According to my version control system, it has been that way since 22/2/2014, which is release V3.3.0b. The only one broken in this particular way is (was) goodreads.

As for testing: I hadn't installed the goodreads plugin before today so I never tested that one. In fact I haven't tested most of the identifier types.

FWIW: here is the complete list of clickable identifiers that CC understands, along with the prototype URLs. This list is from today so the goodreads double-colon error is fixed.
Code:
urlStrings.put("amazon", "http://amzn.com/%s");
urlStrings.put("asin", "http://amzn.com/%s");
urlStrings.put("amazon_fr", "http://www.amazon.fr/dp/%s");
urlStrings.put("amazon_de", "http://www.amazon.de/dp/%s");
urlStrings.put("amazon_uk", "http://www.amazon.co.uk/dp/%s");
urlStrings.put("amazon_it", "http://www.amazon.it/dp/%s");
urlStrings.put("amazon_jp", "http://www.amazon.jp/dp/%s");
urlStrings.put("amazon_es", "http://www.amazon.es/dp/%s");
urlStrings.put("amazon_br", "http://www.amazon.com.br/dp/%s");
urlStrings.put("goodreads", "http://www.goodreads.com/book/show/%s");
urlStrings.put("isbn", "http://www.worldcat.org/isbn/%s");
urlStrings.put("doi", "http://dx.doi.org/%s");
urlStrings.put("arxiv", "http://arxiv.org/abs/%s");
urlStrings.put("oclc", "http://www.worldcat.org/oclc/%s");
urlStrings.put("google", "http://books.google.com/books?id=%s");
urlStrings.put("barnesnoble", "http://www.barnesandnoble.com/%s");
chaley is offline   Reply With Quote