Thread: Instructions for patching firmware 3.18.0
View Single Post
Old 11-20-2015, 06:37 AM   #118
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by JSWolf View Post
Because of the padding patch, doesn't that cause the entire CSS to be ignored since it's now an error? Would it not be better to patch out the %1em to 0em and remove !important instead?
No, the errors that cause problems are in structure. Adding an unknown attribute shouldn't cause a problem. Plus, the way firmware will apply this CSS is different to the in-book stylesheets, so errors in either are unlikely to cause a problem in the other. And finally, by renaming the attribute, the "!important" will mean any padding-bottom in the book won't be overridden.
davidfor is offline   Reply With Quote