View Single Post
Old 11-12-2015, 10:19 AM   #59
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,922
Karma: 6240958
Join Date: Nov 2009
Device: many
Hi DiapDealer,

The bug is in:

bool PluginRunner::checkIsWellFormed()

In this snippet ...

Code:
    if (!xmlFilesToCheck.isEmpty()) {
        foreach (QString href, xhtmlFilesToCheck) {
            // can't really validate without a full dtd so                                                                      
            // auto repair any xml file changes to be safe                                                                      
            QString filePath = m_outputDir + "/" + href;
            ui.statusLbl->setText("Status: checking " + href);
            QString data = Utility::ReadUnicodeTextFile(filePath);
            QString newdata = CleanSource::ProcessXML(data);
            Utility::WriteUnicodeTextFile(newdata, filePath);
        }
    }
It should have been only processing xml files, not xhtml files:

Code:
    if (!xmlFilesToCheck.isEmpty()) {
        foreach (QString href, xmlFilesToCheck) {
            // can't really validate without a full dtd so                                                                      
            // auto repair any xml file changes to be safe                                                                      
            QString filePath = m_outputDir + "/" + href;
            ui.statusLbl->setText("Status: checking " + href);
            QString data = Utility::ReadUnicodeTextFile(filePath);
            QString newdata = CleanSource::ProcessXML(data);
            Utility::WriteUnicodeTextFile(newdata, filePath);
        }
    }
Notice the change in the foreach. This was one of my bug fixes which in turn was broken itself. I will fix this and push the fix to master asap.
We still might want to check out entity handling.

KevinH

ps: fix now pushed to master
pps: rebuilt and I can confirm this fixes the issue my test platform Mac OSX

Last edited by KevinH; 11-12-2015 at 10:27 AM.
KevinH is offline