MobileRead Forums - View Single Post - Sigil-0.8.900 released for testing - Wait for Sigil-0.8.901

KevinH · 09-24-2015, 11:41 PM

Hi,
I think I have a possible fix for this error. It may be happening only on Windows because of how QString toUtf8() returns a QByteArray whose address is actually a pointer to the utf8 string of characters on Linux and Mac but not on Windows. So instead I should be using toUtf8().constData() to get a proper pointer for all platforms.

Each time I took that incorrect shortcut it was in the gumbo_attribute_set_value and other gumbo routines which maps exactly to the symbol table of where the segfaults are happening.

I have pushed the fix and hopefully tomorrow after work DiapDealer will be able to tell us if it was successful.

Thanks for your bug reports. Until we get this nailed down please don't use Windows Sigil-0.8.900 for any type of production "just to be safe".

Thanks!

Kevin

09-24-2015, 11:41 PM	#38
KevinH Sigil Developer Posts: 8,958 Karma: 6361444 Join Date: Nov 2009 Device: many	Hi, I think I have a possible fix for this error. It may be happening only on Windows because of how QString toUtf8() returns a QByteArray whose address is actually a pointer to the utf8 string of characters on Linux and Mac but not on Windows. So instead I should be using toUtf8().constData() to get a proper pointer for all platforms. Each time I took that incorrect shortcut it was in the gumbo_attribute_set_value and other gumbo routines which maps exactly to the symbol table of where the segfaults are happening. I have pushed the fix and hopefully tomorrow after work DiapDealer will be able to tell us if it was successful. Thanks for your bug reports. Until we get this nailed down please don't use Windows Sigil-0.8.900 for any type of production "just to be safe". Thanks! Kevin