Thread: [Metadata Writer Plugin] KePub Metadata Writer
View Single Post
Old 07-02-2015, 01:48 AM   #33
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303826
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Strictly, you are right. But, it was an act to cover all bases in case it hadn't happened for some reason. It probably should have a check to see if it is there and add it if needed.

Actually, there should be a check to make sure the correct image file is selected when the cover is updated. EPUBMedataWriter is doing the actual update. That takes an educated guess, but kepubs have the cover image marked. We should be making sure that only that image is changed. And if no image is marked, choosing one. I do remember thinking about this when I wrote the original code. I hadn't gotten around to revisiting it and had forgotten about it.
davidfor is offline   Reply With Quote