View Single Post
Old 05-09-2015, 03:14 AM   #66
GeoffR
Wizard
GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.GeoffR ought to be getting tired of karma fortunes by now.
 
GeoffR's Avatar
 
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
Thinking about it there could be a problem with the `My 10 line spacing values` patch. I would recommend using the `My 15 line spacing values` patch instead if you are having problems.

The possible problem is that the firmware builds a list of 15 values, and the 10 value patch just skips 5 of the original 15 values and inserts the other ten that it has modified into the slider widget. But when the device reads the saved value for a book from the database, it might search the list of 15 which includes 5 of the original values to try and find a match. It could potentially find a match with one of the values that the 10 value patch skipped, and I don't know what happens in that case.

The 15 value patch modifies the whole list and inserts all 15 values into the slider, so there is no way the firmware can match a value on the list that is not also on the slider.

I think I will remove the `My 10 line spacing values` patch in the future, unless anyone has a good reason for keeping it.

Edit: Just to be clear, I don't know for sure that the `My 10 line spacing values` patch has a problem, I just haven't looked far enough into the code to know what happens with the 5 values that are skipped.

Last edited by GeoffR; 05-09-2015 at 03:32 AM. Reason: Just to be clear ...
GeoffR is offline   Reply With Quote