View Single Post
Old 04-25-2015, 07:47 AM   #196
tshering
Wizard
tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.tshering ought to be getting tired of karma fortunes by now.
 
Posts: 3,489
Karma: 2914715
Join Date: Jun 2012
Device: kobo touch
Quote:
Originally Posted by Markismus View Post
Apparently KSM overwrites the koreader.sh script to adapt it to the new path with one slight oversight on line 12:
Code:
cd /mnt/onboard/.kobo && tar xf $NEWUPDATE && mv $NEWUPDATE $INSTALLED
should be changed to:
Code:
    cd $(dirname $KOREADER_DIR) && tar xf $NEWUPDATE && mv $NEWUPDATE $INSTALLED
Thank you! This was an oversight of mine. Evidently, I do not give enough attention to those parts that I do not use myself.
Quote:
Originally Posted by Markismus View Post
Since the latest nightly (v187) those lines have been changed in the koreader distribution. So your update would only have to be done for the older (stable) revisions of koreader.
Ok, I will do this.


Quote:
Originally Posted by Markismus View Post
Still don't get what triggered the change of the new koreader.sh. Your grep command shouldn't have found that string anymore, right?
Right, the grep command does not find that string. And there is nothing that can get changed by those two sed commands, even if they were executed. Or what change did you see?

Since we are already talking about the koreader.sh, could you consider changing
Code:
if [ -n "$PLATFORM" ]; then
to
Code:
if [ ! -n "${PLATFORM}" ]; then
or similar. Currently the whole block after that line is useless, since it is only execute, if PLATFORM is already defined.


And maybe you could replace
Code:
    # if we were called from advboot then we must reboot to go to the menu
    if [ -d /mnt/onboard/.kobo/advboot ]; then
        reboot
    fi
by something like
Code:
    if [ "$(pidof ksmhome.sh | wc -w)" -lt "1" ]; then
        reboot
    fi
The old script reboots the device if /mnt/onboard/.kobo/advboot exists, even if advboot is not active.
tshering is offline   Reply With Quote