View Single Post
Old 11-13-2014, 03:25 PM   #3485
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,012
Karma: 4604635
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Test Version

Quote:
Originally Posted by watani View Post
I have no problems downloading or viewing the epub with images. The issue has been that within the epub the image HTML tags are not properly made (i.e. longdesc="// instead of longdesc="http://).
....
I'm testing with story URL http://www.fimfiction.net/story/224372/ due to not having any other FimF story with images in to test with.

After downloading, when I examine the contents of the EPUB html file, I do see longdesc missing the 'http:'. I was certain it was there the first time I tried it, so I'm not sure what happened there.

I frankly didn't pay much attention to the issue before since the other guys seemed to have it in hand. However, on review, I found there was a better way to implement the fix that will also work with other sites should it ever come up.

The attached version implements that changed fix.

FFDL is, in point of fact, abusing longdesc. longdesc was meant to link to a 'long description' page for an image. The attribute longdesc is deprecated and not supported by modern browsers. FFDL uses it to store the original image URL in the EPUB because it was the only way I found at the time to do so without causing errors.

FFDL uses the original URL so it knows when it does and does not need to download new additional images when there's an update and to reuse existing images when the same image is included in the story more than once.

Last edited by JimmXinu; 11-15-2014 at 03:10 PM. Reason: Remove obsolete test versions - replaced by newer test or released version.
JimmXinu is offline