Hi varlog,
Quote:
Originally Posted by varlog
Out of courtesy I don't submit patches that I know will be rejected. It is just a waste of time for all. On the other hand I find this functionality so cool that I just have to share  .
And hey, I don't code in python. Never learned it. |
I don't understand ... how do you know your patch will be rejected without trying? Is it unsound in some way? Is there some evident problem? Does it cause an instability? If so, you probably should not be posting the patch at all.
If not, you should probably be submitting it for review via a pull request or by simply sending your patch to user-none. At worst, he says no, at best it gets included and helps others. He has included some of your patches in the past and has rejected others.
And in fairness to the ones he rejected, you did not do a very good job of explaining what the patch was for and why others might benefit. Simply saying "you need this but not explaining why or how others might benefit" is not a good way to get any patch accepted.
KevinH