Hi Kevin,
Quote:
Originally Posted by KevinH
I would prefer we explicitly use ordered dicts only where needed (and none are actually truly needed here ... ). If you have some justification as to why you need an ordered dict then import it as something other than dict and use it only where needed explicitly.
|
I compare the unpacking results of two versions by a diff command or a GUI diff tool. Using the ordered dictionaries makes testing easier greatly. I have found the necessary dictionaryies to be needed keeping orders are metadata in mobi_header and tattr in mobi_k8resc.py for my demand.
So, could you change dict to OrderedDict if acceptable for you?
BTW, are there any case that keeping the oders of data in a mobi helps to understand the functionality of kindlegen better?
Quote:
|
If you can fix both of these and have a github account, please create a fork and pull request, so that you get the proper credit in the history.
|
I have made a new patch; but, I do not have any github account. Could you update it on my behalf?
Thanks,