View Single Post
Old 10-25-2014, 10:35 AM   #1086
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,958
Karma: 6361444
Join Date: Nov 2009
Device: many
Hi tkeo,
Do we really need to overwrite all dictionaries with ordered dictionaries?

I would prefer we explicitly use ordered dicts only where needed (and none are actually truly needed here ... ). If you have some justification as to why you need an ordered dict then import it as something other than dict and use it only where needed explicitly.

Also, the flake8 style checks require a space after the "#" for comments. Better yet simply delete those extra HtmlParser related lines since the compatibility_utils unescapeit removes their use completely.

If you can fix both of these and have a github account, please create a fork and pull request, so that you get the proper credit in the history.

Thanks,

Kevin

Last edited by KevinH; 10-25-2014 at 03:11 PM. Reason: updated now that I understand that dict() is a builtin for a normal dictionary
KevinH is online now   Reply With Quote