Quote:
Originally Posted by KevinH
So please don't bother to offer pull requests for line length issues or whitespace issues that are not related to indentation issues. Only changes that actually or potentially impact functionality will considered.
That should bring that 2188 down to a more reasonable level!
|
I do agree with ignoring of some errors which aren't errors but just artifacts of custom developed style.
There is also another point wrt flake8. Given openness for contribution, is it a reasonable goal to have automated style check for keeping (enforcing) style consistency? If so, flake8 can help with it.
flake8 is just a wrapper for pep8, pyflakes and McCabe tools (with McCabe deactivated by default). flake8 (pep8) tool policy could be changed to the limit (
flake8 configuration) with per-project settings file (which could be commited to repository). For example, maximum line length (checked by pep8 tool) could be increased to 119 characters (as in
Django coding style, to align with width of GitHub code review) or any other arbitrary but fixed value. pep8 errors reporting could be disabled either globally (with settings file, by whitelisting or blacklisting several errors) or locally (with special comment after line where error reporting should be disabled, but only for some selected errors). flake8 will also not check files with
# flake8: noqa comment.
Providing different flake8 settings for checking Python2/Python3 code could be automated with
tox. tox is useful anyway for making things run against different Python versions in testing purposes.
I'm not trying to set any priority for using flake8. It was just a small tour into its configurability.