Thread: [GUI Plugin] Modify ePub
View Single Post
Old 07-22-2014, 02:09 AM   #747
Rev. Bob
Wizard
Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.
 
Rev. Bob's Avatar
 
Posts: 1,760
Karma: 9918418
Join Date: Feb 2013
Location: Here on the perimeter, there are no stars
Device: Kobo H2O, iPad mini 3, Kindle Touch
Quote:
Originally Posted by davidfor View Post
I did notice one problem with it. Sometimes the first tag after the body was still indented. Mostly this was a h2, but I did find a paragraph as well.
Hmm. Got a code sample I can test with?

Quote:
Originally Posted by davidfor
Another thing that occurred to me was what if someone added a style for "span"? This would be used for classless spans. Removing them would lose formatting. Of course, it would be a stupid thing to do. I style p and the heading tags directly, but a span or div would be a bad idea.
That is a possibility, granted...but there's really no way to check for it in the plugin. That's just one of those places where keeping a backup is always wise.

Quote:
Originally Posted by davidfor
The only other thing is that the dialog is unbalanced. I had a play, but I couldn't come up with a layout I was completely happy with. I did make changes to dialog.py to make fiddling with this easier. I'll send you a link to this so you can try.
I think that's something I'd rather leave to kiwidude, since the divisions are his categories. Also, there's the whole "handle the chrome last" thing; I'm much more comfortable with getting the code right and having kiwidude decide he'd like to rejigger the GUI than I am with inventing the perfect GUI for a plugin that butchers code.
Rev. Bob is offline   Reply With Quote