MobileRead Forums - View Single Post

davidfor · 07-22-2014, 01:07 AM

I have had a play and it is working well. Strangely, I find I like the un-pretty option. And it doesn't do any real harm as I can press the pretty button in the editor if I need to.

I did notice one problem with it. Sometimes the first tag after the body was still indented. Mostly this was a h2, but I did find a paragraph as well.

Another thing that occurred to me was what if someone added a style for "span"? This would be used for classless spans. Removing them would lose formatting. Of course, it would be a stupid thing to do. I style p and the heading tags directly, but a span or div would be a bad idea.

The only other thing is that the dialog is unbalanced. I had a play, but I couldn't come up with a layout I was completely happy with. I did make changes to dialog.py to make fiddling with this easier. I'll send you a link to this so you can try.

07-22-2014, 01:07 AM	#746
davidfor Grand Sorcerer Posts: 24,905 Karma: 47303824 Join Date: Jul 2011 Location: Sydney, Australia Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos	I have had a play and it is working well. Strangely, I find I like the un-pretty option. And it doesn't do any real harm as I can press the pretty button in the editor if I need to. I did notice one problem with it. Sometimes the first tag after the body was still indented. Mostly this was a h2, but I did find a paragraph as well. Another thing that occurred to me was what if someone added a style for "span"? This would be used for classless spans. Removing them would lose formatting. Of course, it would be a stupid thing to do. I style p and the heading tags directly, but a span or div would be a bad idea. The only other thing is that the dialog is unbalanced. I had a play, but I couldn't come up with a layout I was completely happy with. I did make changes to dialog.py to make fiddling with this easier. I'll send you a link to this so you can try.