Hi,
Yes, please go ahead and post just the new mobi_split.py code if there is a significant speed improvement. That way people can drop it in whatever version of KindleUnpack they currently use for testing purposes.
I will take a look at the opf code and all of your new routines and let you know what I think. I'll be traveling for the next week and out of reach of the internet. So please take a shot at whatever approach you feel is best and I will do the same and we can compare approaches upon my return.
Thanks,
KevinH
Quote:
Originally Posted by tkeo
Hi Kevin,
I feel the necessity of discussion to modify 'mobi_opf.py,' so I have not touched.
Followings are in my mind,
1. The most redundant part is manifest generation. Is it better to merge buildOPFManifest() and buildEPUB2OPFManifest() to buildEPUB3OPFManifest(), and rename buildEPUB3OPFManifest()? Personally, I prefer to merge.
2. I think it is better to merge writeK8OPF() to writeOPF().
3. Keeping buildOPF() to be separated because merging it cause many 'if statments' and decrease readability, it may better to merge buildEPUB2OPF() and buildEPUB3OPF() to buildK8OPF().
4. removing constants OPF_NAME, TOC_NCX and NAVIGATION_DOCUMENT, and changing to hard code due to almost no necessity.
Besides, I have modified 'mobi_split.py' to make processing faster. I have considered to post it after v0.73 release in oder to avoid more testing. But I will post it if some one want.
Thanks,
|