Thread: [GUI Plugin] FanFictionDownLoader
View Single Post
Old 06-09-2014, 07:45 AM   #2881
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,043
Karma: 4604637
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by cryzed View Post
@Jimm
I'm pretty sure that this is still a bug relating to merging the stories though. Why does an adapter need to provide "numWords"? There's a bug somewhere in "merge_meta_books" in the "ffdl_plugin.py" line 1992. Somehow the standard story metadata has a bunch of default keys, like "numWords" and "numChapters" with empty values. In the method it now runs into an error, because it expects both fields to have a valid value just because the keys are contained in the metadata. I think the easiest way would be to check "if book['all_metadata'][k] and b['all_metadata'][k]" before working with the values in the method -- your call! Also attached is a possible fix, it seems to work for me.
Can you provide a couple story URLs that demonstrate the problem? I'm not finding any where that pre-sets numWords to None. numChapters is required. If there's no chapters at all, there's no story.
JimmXinu is offline