|
You could have done a pull request. That is what I and other "known" calibre developers do. The main reasons to submit a patch using launchpad are to avoid learning how github works, to avoid a github account and the associated repo, and to let Kovid get to know you. That last one is the least important, as I know from personal experience that he is fully able and willing to carry on a dialog using github comments.
Welcome to the community!
Ahh, email just arrived saying Kovid assigned accepting the patch to me. Could you give me your banking details so that I can verify that you are a real human being? (Smile) More seriously, I will look at it and converse as necessary on launchpad. Once we arrive at a conclusion, I will almost certainly ask you to submit the agreed patch to Kovid using github.
|